2017-07-24 06:34 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001773openmediavaultBugpublic2017-07-10 16:57
Reporterdethegeek 
Assigned Tovotdev 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Platformx86_64OSOS Version
Product VersionErasmus (3.x) 
Target VersionFixed in VersionErasmus (3.x) 
Summary0001773: UID_MAX and GID_MAX from login.defs not read
DescriptionAfter joining OMV 3 to my Samba4 domain with ldap_id_mapping my uid and gid have very high values (numbers with 9 digits).

However if I edit /etc/login.defs to change UID_MAX and GID_MAX to allow my users and groups to show in the web interface I found my new setting is ignored.
Steps To Reproducecreate a user with uid > 60000 (after a debug session and fix, I think using a samba 4 domain is not needed)

browse through the web UI and observe the user does not show.
Additional InformationI found 2 problems in the code, and solved them with the attached patch
TagsNo tags attached.
Product build3.0.79
Attached Files
  • diff file icon omv-fix.diff (629 bytes) 2017-07-10 11:19 -
    diff --git a/deb/openmediavault/usr/share/php/openmediavault/system/system.inc b/deb/openmediavault/usr/share/php/openmediavault/system/system.inc
    index 55519bf..c96a5b2 100644
    --- a/deb/openmediavault/usr/share/php/openmediavault/system/system.inc
    +++ b/deb/openmediavault/usr/share/php/openmediavault/system/system.inc
    @@ -88,7 +88,8 @@
     		// # System accounts
     		// #SYS_UID_MIN              100
     		// #SYS_UID_MAX              999
    -		$file = new \OMV\Util\KeyValueFile("/etc/login.defs");
    +		$file = new \OMV\Util\KeyValueFile("/etc/login.defs", "\\s");
    +		$file->setKeyCaseSensitiv(TRUE);
     		return $file->getAssoc();
     	}
     
    
    diff file icon omv-fix.diff (629 bytes) 2017-07-10 11:19 +

-Relationships
+Relationships

-Notes

~0004841

dethegeek (reporter)

After this bug is solved I'll be able make a bit simpler my guide (in BETA) to use SSSD in OMV to join an AD.

~0004842

votdev (administrator)

Thanks for debugging this issue. It seems to be a regression when the \OMV\Util\KeyValueFile was introduced.

~0004843

votdev (administrator)

Fixed in openmediavault 3.0.83, see https://github.com/openmediavault/openmediavault/commit/77f9934f8bff70b2a5e6d45a5caf3d9b0d242826.
+Notes

-Issue History
Date Modified Username Field Change
2017-07-10 11:19 dethegeek New Issue
2017-07-10 11:19 dethegeek Status new => assigned
2017-07-10 11:19 dethegeek Assigned To => votdev
2017-07-10 11:19 dethegeek File Added: omv-fix.diff
2017-07-10 11:23 dethegeek Note Added: 0004841
2017-07-10 11:32 votdev Note Added: 0004842
2017-07-10 16:57 votdev Status assigned => resolved
2017-07-10 16:57 votdev Resolution open => fixed
2017-07-10 16:57 votdev Fixed in Version => Erasmus (3.x)
2017-07-10 16:57 votdev Note Added: 0004843
+Issue History