2017-04-23 23:37 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001718openmediavaultFeaturepublic2017-04-10 16:53
Reportertkaiser 
Assigned Tovotdev 
PrioritylowSeveritytweakReproducibilityalways
StatusresolvedResolutionno change required 
PlatformODROID-C2OSOMV Erasmus / JessieOS Version3.0.69 / 8.7
Product Version 
Target VersionFixed in VersionErasmus (3.x) 
Summary0001718: /etc/default/cpufrequtils gets overwritten
DescriptionAs part of the initial OMV installation or every time 'Power Management' settings are changed /etc/default/cpufrequtils gets overwritten with the following contents:

    ENABLE="true"
    GOVERNOR="conservative"
    MAX_SPEED="0"
    MIN_SPEED="0"

While 'conservative' might be a good choice on x86/x64 it's not that good in general on armhf and arm64 platforms since there's not always mainline kernel available and vendor kernels (Amlogic in this case) behave badly. I did some storage testing a while back and conservative shows serious and unnecessary performance drops: https://github.com/igorpecovnik/lib/issues/499#issuecomment-253481174
Steps To ReproduceSet performance governor:

    sed -i 's/^GOVERNOR=.*/GOVERNOR=performance/' /etc/default/cpufrequtils

Check the setting:

    cat /etc/default/cpufrequtils

Change something related to 'Power managament' in the Web UI, save changes and check again:

    cat /etc/default/cpufrequtils
Additional InformationSince Armbian team currently modifies our build script to provide OMV images generated from scratch for 0000039:0000050 Ethernet equipped SBC we support -- background info: http://forum.openmediavault.org/index.php/Thread/17855 -- I would propose checking output of 'dpkg --print-architecture' and if it's either armhf or arm64 then not touching cpufrequtils configuration.

In Armbian we always do extensive testing with new devices we support and based on the kernel variant used decide then which cpufreq governor is the best. For example on SBC based on Allwinner's A64 SoC (Pine64+, NanoPi NEO A64, Banana Pi M64, Orange Pi Win) from a NAS point of view 'interactive' is best performing governor with 'legacy' kernel (3.10.x from Allwinner) while ondemand/conservative could/should be used with mainline kernel.

Since Armbian's /etc/init.d/cpufrequtils contents are the result of a 'per board' *and* 'per kernel' optimization and testing process I would prefer to not touch these defaults.
Tagsarm64, armhf, erasmus, performance
Attached Files

-Relationships
+Relationships

-Notes

~0004698

votdev (administrator)

The governor can be set via OMV_CPUFREQUTILS_GOVERNOR environment variable in /etc/default/openmediavault and will take action if the config files are generated via 'omv-mkconf cpufrequtils'.

If this does not help you please contribute a suggestion by opening a pull request on Github.

~0004699

tkaiser (reporter)

Great, the two other variables are there and used to, so simply appending defaults to /etc/default/openmediavault will already do the job!

Successfully tested with

OMV_CPUFREQUTILS_GOVERNOR=ondemand
OMV_CPUFREQUTILS_MINSPEED=500000
OMV_CPUFREQUTILS_MAXSPEED=1536000

Entry can be closed.

~0004700

votdev (administrator)

The following changes have been made, maybe this helps. See https://github.com/openmediavault/openmediavault/commit/7f99e9c22be68a0b3d8d39ab6dcbccdd290a9ad0.
+Notes

-Issue History
Date Modified Username Field Change
2017-04-10 13:30 tkaiser New Issue
2017-04-10 13:30 tkaiser Status new => assigned
2017-04-10 13:30 tkaiser Assigned To => votdev
2017-04-10 13:30 tkaiser Tag Attached: erasmus
2017-04-10 13:30 tkaiser Tag Attached: arm64
2017-04-10 13:30 tkaiser Tag Attached: armhf
2017-04-10 13:30 tkaiser Tag Attached: performance
2017-04-10 13:37 votdev Note Added: 0004698
2017-04-10 14:40 tkaiser Note Added: 0004699
2017-04-10 16:53 votdev Status assigned => resolved
2017-04-10 16:53 votdev Resolution open => no change required
2017-04-10 16:53 votdev Fixed in Version => Erasmus (3.x)
2017-04-10 16:53 votdev Note Added: 0004700
+Issue History